Code Review for webrev

Prepared by: Jorn Vernee on Tue Jun 23 11:38:04 UTC 2020
Compare against: https://git.openjdk.java.net/panama-foreign
Compare against version: 54e3c3e0
Summary of changes: 1036 lines changed; 773 ins; 215 del; 48 mod; 1686 unchg
Patch of changes: webrev.patch
Pull request: 212
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/Binding.java

1f5a6b27: - Replace Binding interpreter, verification, and specialization switches with virtual calls to method on Binding.
b70edf14: Implement binding recipe specialization with MethodHandles  
374 lines changed; 374 ins; 0 del; 0 mod; 576 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/BindingInterpreter.java

1f5a6b27: - Replace Binding interpreter, verification, and specialization switches with virtual calls to method on Binding.
b70edf14: Implement binding recipe specialization with MethodHandles  
142 lines changed; 0 ins; 133 del; 9 mod; -86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/CallingSequence.java

b70edf14: Implement binding recipe specialization with MethodHandles  
13 lines changed; 12 ins; 0 del; 1 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/CallingSequenceBuilder.java

1f5a6b27: - Replace Binding interpreter, verification, and specialization switches with virtual calls to method on Binding.  
77 lines changed; 0 ins; 73 del; 4 mod; 32 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/ProgrammableInvoker.java

1f5a6b27: - Replace Binding interpreter, verification, and specialization switches with virtual calls to method on Binding.
ab349284: Fix whitespace errors
b70edf14: Implement binding recipe specialization with MethodHandles  
215 lines changed; 187 ins; 8 del; 20 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/ProgrammableUpcallHandler.java

1f5a6b27: - Replace Binding interpreter, verification, and specialization switches with virtual calls to method on Binding.
b70edf14: Implement binding recipe specialization with MethodHandles  
12 lines changed; 6 ins; 0 del; 6 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/SharedUtils.java

1f5a6b27: - Replace Binding interpreter, verification, and specialization switches with virtual calls to method on Binding.
b70edf14: Implement binding recipe specialization with MethodHandles  
77 lines changed; 77 ins; 0 del; 0 mod; 395 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/foreign/TestDowncall.java

b70edf14: Implement binding recipe specialization with MethodHandles  
7 lines changed; 6 ins; 0 del; 1 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/foreign/TestUpcall.java

b70edf14: Implement binding recipe specialization with MethodHandles  
14 lines changed; 6 ins; 1 del; 7 mod; 211 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/micro/org/openjdk/bench/jdk/incubator/foreign/CallOverhead.java

638b8e0b: Fix whitespace errors
1f5a6b27: - Replace Binding interpreter, verification, and specialization switches with virtual calls to method on Binding.
b70edf14: Implement binding recipe specialization with MethodHandles  
88 lines changed; 88 ins; 0 del; 0 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/micro/org/openjdk/bench/jdk/incubator/foreign/libCallOverhead.c

1f5a6b27: - Replace Binding interpreter, verification, and specialization switches with virtual calls to method on Binding.  
17 lines changed; 17 ins; 0 del; 0 mod; 34 unchg

This code review page was prepared using webrev version ca39c57bf150c55fce30c74e2756b7afb0aa0645