Code Review for webrev

Prepared by: Jorn Vernee on Tue Jun 16 15:09:29 UTC 2020
Compare against: https://git.openjdk.java.net/panama-foreign
Compare against version: 17bd644c
Summary of changes: 281 lines changed; 183 ins; 76 del; 22 mod; 2626 unchg
Patch of changes: webrev.patch
Pull request: 208
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CSupport.java

c34cebc8: - Add VaList.empty  
14 lines changed; 14 ins; 0 del; 0 mod; 697 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/SharedUtils.java

c34cebc8: - Add VaList.empty  
102 lines changed; 102 ins; 0 del; 0 mod; 293 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/x64/sysv/SysVVaList.java

c34cebc8: - Add VaList.empty  
36 lines changed; 31 ins; 4 del; 1 mod; 406 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/x64/sysv/SysVx64Linker.java

c34cebc8: - Add VaList.empty  
42 lines changed; 1 ins; 32 del; 9 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/x64/windows/WinVaList.java

c34cebc8: - Add VaList.empty
d47fd595: Work around test failures where the test tries to create an empty VaList, by allocating a 1 byte dummy segment in that case.  
18 lines changed; 10 ins; 4 del; 4 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/x64/windows/Windowsx64Linker.java

c34cebc8: - Add VaList.empty  
46 lines changed; 4 ins; 36 del; 6 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/foreign/StdLibTest.java

c34cebc8: - Add VaList.empty  
9 lines changed; 7 ins; 0 del; 2 mod; 485 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/foreign/valist/VaListTest.java

c34cebc8: - Add VaList.empty  
14 lines changed; 14 ins; 0 del; 0 mod; 363 unchg

This code review page was prepared using webrev version 6b9b00c8b50f98ced78a87e0681ce5295fbf8044