Code Review for webrev

Compare against revision: 055db4fc
Summary of changes: 6163 lines changed; 3069 ins; 3076 del; 18 mod; 1376 unchg
Patch of changes: webrev.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/coverage/pom.xml

22 lines changed; 0 ins; 11 del; 11 mod; 495 unchg

------ ------ ------ ------ Old --- Patch Raw application/org.openjdk.jmc.jdp/build.properties

37 lines changed; 0 ins; 37 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/org.openjdk.jmc.jdp/pom.xml

68 lines changed; 0 ins; 68 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/Discoverable.java

53 lines changed; 0 ins; 53 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/DiscoveryEvent.java

80 lines changed; 0 ins; 80 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/DiscoveryListener.java

47 lines changed; 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/JDPClient.java

109 lines changed; 0 ins; 109 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/PacketListener.java

92 lines changed; 0 ins; 92 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/PacketProcessor.java

125 lines changed; 0 ins; 125 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/Pruner.java

120 lines changed; 0 ins; 120 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/package-info.java

37 lines changed; 0 ins; 37 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/CodingException.java

48 lines changed; 0 ins; 48 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/Configuration.java

84 lines changed; 0 ins; 84 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/ConfigurationFactory.java

88 lines changed; 0 ins; 88 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/JDPPacket.java

234 lines changed; 0 ins; 234 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/JRockitJDPPacketDecoder.java

169 lines changed; 0 ins; 169 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/package-info.java

38 lines changed; 0 ins; 38 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/jmx/JMXDataKeys.java

44 lines changed; 0 ins; 44 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/pom.xml

8 lines changed; 5 ins; 1 del; 2 mod; 183 unchg

------ ------ ------ ------ Old --- Patch Raw application/tests/org.openjdk.jmc.jdp.test/build.properties

37 lines changed; 0 ins; 37 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/tests/org.openjdk.jmc.jdp.test/pom.xml

60 lines changed; 0 ins; 60 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/AllTests.java

51 lines changed; 0 ins; 51 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/ClientTester.java

108 lines changed; 0 ins; 108 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/ServerTester.java

214 lines changed; 0 ins; 214 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/JDPClientTest.java

138 lines changed; 0 ins; 138 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/JDPJMXTest.java

97 lines changed; 0 ins; 97 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/JDPPacketTest.java

87 lines changed; 0 ins; 87 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/JDPServerTest.java

127 lines changed; 0 ins; 127 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/TestToolkit.java

151 lines changed; 0 ins; 151 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/server/Broadcaster.java

111 lines changed; 0 ins; 111 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/server/JDPServer.java

210 lines changed; 0 ins; 210 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/server/jmx/JMXJDPServer.java

105 lines changed; 0 ins; 105 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/server/jmx/PIDHelper.java

56 lines changed; 0 ins; 56 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/server/jmx/package-info.java

38 lines changed; 0 ins; 38 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/pom.xml

2 lines changed; 0 ins; 1 del; 1 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/coverage/pom.xml

13 lines changed; 10 ins; 0 del; 3 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.jdp/.classpath (was application/org.openjdk.jmc.jdp/.classpath)

0 lines changed; 0 ins; 0 del; 0 mod; 7 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.jdp/.project (was application/org.openjdk.jmc.jdp/.project)

0 lines changed; 0 ins; 0 del; 0 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.jdp/.settings/org.eclipse.jdt.core.prefs (was application/org.openjdk.jmc.jdp/.settings/org.eclipse.jdt.core.prefs)

0 lines changed; 0 ins; 0 del; 0 mod; 7 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.jdp/META-INF/MANIFEST.MF (was application/org.openjdk.jmc.jdp/META-INF/MANIFEST.MF)

0 lines changed; 0 ins; 0 del; 0 mod; 11 unchg

------ ------ ------ ------ --- New Patch Raw core/org.openjdk.jmc.jdp/build.properties

37 lines changed; 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/org.openjdk.jmc.jdp/pom.xml

46 lines changed; 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/Discoverable.java

53 lines changed; 53 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/DiscoveryEvent.java

80 lines changed; 80 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/DiscoveryListener.java

47 lines changed; 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/JDPClient.java

109 lines changed; 109 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/PacketListener.java

92 lines changed; 92 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/PacketProcessor.java

125 lines changed; 125 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/Pruner.java

120 lines changed; 120 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/package-info.java

37 lines changed; 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/CodingException.java

48 lines changed; 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/Configuration.java

84 lines changed; 84 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/ConfigurationFactory.java

88 lines changed; 88 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/JDPPacket.java

234 lines changed; 234 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/JRockitJDPPacketDecoder.java

169 lines changed; 169 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/package-info.java

38 lines changed; 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/jmx/JMXDataKeys.java

44 lines changed; 44 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/pom.xml

1 lines changed; 1 ins; 0 del; 0 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.jdp.test/.classpath (was application/tests/org.openjdk.jmc.jdp.test/.classpath)

0 lines changed; 0 ins; 0 del; 0 mod; 7 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.jdp.test/.project (was application/tests/org.openjdk.jmc.jdp.test/.project)

0 lines changed; 0 ins; 0 del; 0 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.jdp.test/META-INF/MANIFEST.MF (was application/tests/org.openjdk.jmc.jdp.test/META-INF/MANIFEST.MF)

0 lines changed; 0 ins; 0 del; 0 mod; 11 unchg

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.jdp.test/build.properties

37 lines changed; 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.jdp.test/pom.xml

71 lines changed; 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/AllTests.java

51 lines changed; 51 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/ClientTester.java

108 lines changed; 108 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/ServerTester.java

214 lines changed; 214 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/JDPClientTest.java

138 lines changed; 138 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/JDPJMXTest.java

97 lines changed; 97 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/JDPPacketTest.java

87 lines changed; 87 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/JDPServerTest.java

127 lines changed; 127 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/TestToolkit.java

151 lines changed; 151 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/server/Broadcaster.java

111 lines changed; 111 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/server/JDPServer.java

210 lines changed; 210 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/server/jmx/JMXJDPServer.java

105 lines changed; 105 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/server/jmx/PIDHelper.java

56 lines changed; 56 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/server/jmx/package-info.java

38 lines changed; 38 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/pom.xml

2 lines changed; 1 ins; 0 del; 1 mod; 152 unchg

This code review page was prepared using webrev version 'unknown'