Code Review for webrev

Prepared by: Thiago Milczarek Sayao on Fri Jun 12 13:35:58 UTC 2020
Compare against: https://git.openjdk.java.net/jfx
Compare against version: b2008913
Summary of changes: 7030 lines changed; 7014 ins; 0 del; 16 mod; 2480 unchg
Patch of changes: webrev.patch
Pull request: 77
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildSrc/linux.gradle

ad8823de: Merge branch 'master' into jdk_8236651
2700f6fb: Limit GTK on 3.8
9c83ac12: Limit GTK on 3.18 (Ubuntu 16.04)
7d350bc6: Fix build with merged linux.gradle
8888fa42: Merge branch 'master' into jdk_8236651
e1b03727: Merge pull request #9 from openjdk/master
85defa52: Rename flag to javafx.gtk.experimental
9fa65e6d: Rename flag to javafx.gtk.experimental
8973d385: JDK-8236651 Simplify and update glass gtk backend
de2d5171: Merge pull request #8 from openjdk/master  
29 lines changed; 28 ins; 0 del; 1 mod; 331 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkApplication.java

9fa65e6d: Rename flag to javafx.gtk.experimental
d18b5be4: Restore comment position
8973d385: JDK-8236651 Simplify and update glass gtk backend  
14 lines changed; 10 ins; 0 del; 4 mod; 477 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkWindow.java

9fa65e6d: Rename flag to javafx.gtk.experimental
8973d385: JDK-8236651 Simplify and update glass gtk backend  
14 lines changed; 3 ins; 0 del; 11 mod; 226 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/GlassApplication.cpp

9fa65e6d: Rename flag to javafx.gtk.experimental  
473 lines changed; 473 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/GlassCommonDialogs.cpp

9fa65e6d: Rename flag to javafx.gtk.experimental  
291 lines changed; 291 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/GlassCursor.cpp

9fa65e6d: Rename flag to javafx.gtk.experimental  
260 lines changed; 260 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/GlassDnDClipboard.cpp (copied from modules/javafx.graphics/src/main/native-glass/gtk/GlassDnDClipboard.cpp)

9fa65e6d: Rename flag to javafx.gtk.experimental  
0 lines changed; 0 ins; 0 del; 0 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/GlassPixels.cpp (copied from modules/javafx.graphics/src/main/native-glass/gtk/GlassPixels.cpp)

9fa65e6d: Rename flag to javafx.gtk.experimental  
0 lines changed; 0 ins; 0 del; 0 mod; 125 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/GlassRobot.cpp

9fa65e6d: Rename flag to javafx.gtk.experimental  
276 lines changed; 276 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/GlassSystemClipboard.cpp (copied from modules/javafx.graphics/src/main/native-glass/gtk/GlassSystemClipboard.cpp)

9fa65e6d: Rename flag to javafx.gtk.experimental  
0 lines changed; 0 ins; 0 del; 0 mod; 664 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/GlassTimer.cpp (copied from modules/javafx.graphics/src/main/native-glass/gtk/GlassTimer.cpp)

9fa65e6d: Rename flag to javafx.gtk.experimental  
0 lines changed; 0 ins; 0 del; 0 mod; 97 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/GlassView.cpp

9fa65e6d: Rename flag to javafx.gtk.experimental  
285 lines changed; 285 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/GlassWindow.cpp

9fa65e6d: Rename flag to javafx.gtk.experimental  
617 lines changed; 617 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/glass_dnd.cpp

2700f6fb: Limit GTK on 3.8
9fa65e6d: Rename flag to javafx.gtk.experimental  
953 lines changed; 953 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/glass_dnd.h

9fa65e6d: Rename flag to javafx.gtk.experimental  
90 lines changed; 90 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/glass_evloop.cpp (copied from modules/javafx.graphics/src/main/native-glass/gtk/glass_evloop.cpp)

9fa65e6d: Rename flag to javafx.gtk.experimental  
0 lines changed; 0 ins; 0 del; 0 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/glass_evloop.h (copied from modules/javafx.graphics/src/main/native-glass/gtk/glass_evloop.h)

9fa65e6d: Rename flag to javafx.gtk.experimental  
0 lines changed; 0 ins; 0 del; 0 mod; 41 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/glass_general.cpp

9c83ac12: Limit GTK on 3.18 (Ubuntu 16.04)
9fa65e6d: Rename flag to javafx.gtk.experimental  
777 lines changed; 777 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/glass_general.h

9fa65e6d: Rename flag to javafx.gtk.experimental  
334 lines changed; 334 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/glass_key.cpp

9fa65e6d: Rename flag to javafx.gtk.experimental  
348 lines changed; 348 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/glass_key.h (copied from modules/javafx.graphics/src/main/native-glass/gtk/glass_key.h)

9fa65e6d: Rename flag to javafx.gtk.experimental  
0 lines changed; 0 ins; 0 del; 0 mod; 39 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/glass_screen.cpp

9c83ac12: Limit GTK on 3.18 (Ubuntu 16.04)
e947aa66: Forgot a g_print
9fa65e6d: Rename flag to javafx.gtk.experimental  
237 lines changed; 237 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/glass_screen.h (copied from modules/javafx.graphics/src/main/native-glass/gtk/glass_screen.h)

9fa65e6d: Rename flag to javafx.gtk.experimental  
0 lines changed; 0 ins; 0 del; 0 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/glass_view.h (copied from modules/javafx.graphics/src/main/native-glass/gtk/glass_view.h)

9fa65e6d: Rename flag to javafx.gtk.experimental  
0 lines changed; 0 ins; 0 del; 0 mod; 38 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/glass_window.cpp

9c83ac12: Limit GTK on 3.18 (Ubuntu 16.04)
e947aa66: Forgot a g_print
3e3aa584: Fix window position bug
9fa65e6d: Rename flag to javafx.gtk.experimental  
1477 lines changed; 1477 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/glass_window.h

9fa65e6d: Rename flag to javafx.gtk.experimental  
280 lines changed; 280 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/glass_window_ime.cpp

9fa65e6d: Rename flag to javafx.gtk.experimental  
275 lines changed; 275 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/wrapped.c (copied from modules/javafx.graphics/src/main/native-glass/gtk/wrapped.c)

9fa65e6d: Rename flag to javafx.gtk.experimental  
0 lines changed; 0 ins; 0 del; 0 mod; 150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/native-glass/gtk_experimental/wrapped.h (copied from modules/javafx.graphics/src/main/native-glass/gtk/wrapped.h)

9fa65e6d: Rename flag to javafx.gtk.experimental  
0 lines changed; 0 ins; 0 del; 0 mod; 50 unchg

This code review page was prepared using webrev version 6b9b00c8b50f98ced78a87e0681ce5295fbf8044