Code Review for webrev

Prepared by: Johan Vos on Mon Jun 15 15:32:19 UTC 2020
Compare against: https://git.openjdk.java.net/jfx
Compare against version: 2d98fe6c
Summary of changes: 155 lines changed; 146 ins; 2 del; 7 mod; 725 unchg
Patch of changes: webrev.patch
Pull request: 249
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/javafx/font/freetype/OSPango.java

0eed97d5: Use number of real characters when obtaining pointers in a string.  
1 lines changed; 1 ins; 0 del; 0 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/javafx/font/freetype/PangoGlyphLayout.java

0d6e9093: use LinkedHashMap instead of HashMap
998f55c6: process reviewer comments: start == str
d345c744: Add check for 0 in text
e9184be4: allow different TextRuns to share the same UTF 16 text, but create separate
0eed97d5: Use number of real characters when obtaining pointers in a string.  
17 lines changed; 8 ins; 2 del; 7 mod; 196 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/native-font/pango.c

0eed97d5: Use number of real characters when obtaining pointers in a string.  
7 lines changed; 7 ins; 0 del; 0 mod; 435 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/test/java/test/com/sun/javafx/font/freetype/PangoTest.java

cc178e77: use latest patterns in system test
8c6e73a0: Add test for testing Pango behavior with Character(0) and surrogate pairs  
130 lines changed; 130 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using webrev version 6b9b00c8b50f98ced78a87e0681ce5295fbf8044