Code Review for webrev

Prepared by: Johan Vos on Wed Jun 10 12:02:12 UTC 2020
Compare against: https://git.openjdk.java.net/jfx
Compare against version: 2d98fe6c
Summary of changes: 44 lines changed; 37 ins; 1 del; 6 mod; 956 unchg
Patch of changes: webrev.patch
Pull request: 249
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/javafx/font/freetype/OSPango.java

0eed97d5: Use number of real characters when obtaining pointers in a string.  
1 lines changed; 1 ins; 0 del; 0 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/javafx/font/freetype/PangoGlyphLayout.java

d345c744: Add check for 0 in text
e9184be4: allow different TextRuns to share the same UTF 16 text, but create separate
0eed97d5: Use number of real characters when obtaining pointers in a string.  
18 lines changed; 11 ins; 1 del; 6 mod; 199 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/native-font/pango.c

0eed97d5: Use number of real characters when obtaining pointers in a string.  
7 lines changed; 7 ins; 0 del; 0 mod; 435 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/test/java/test/com/sun/javafx/text/TextLayoutTest.java

d345c744: Add check for 0 in text
e9184be4: allow different TextRuns to share the same UTF 16 text, but create separate  
18 lines changed; 18 ins; 0 del; 0 mod; 228 unchg

This code review page was prepared using webrev version 6b9b00c8b50f98ced78a87e0681ce5295fbf8044