Code Review for webrev

Prepared by: sashamatveev on Fri May 29 22:28:14 UTC 2020
Compare against: https://git.openjdk.java.net/jfx
Compare against version: 3ceee699
Summary of changes: 10110 lines changed; 5391 ins; 4060 del; 659 mod; 7349 unchg
Patch of changes: webrev.patch
Pull request: 242
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.media/src/main/legal/libffi.md

dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
2 lines changed; 0 ins; 0 del; 2 mod; 26 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/LICENSE

dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
1 lines changed; 0 ins; 0 del; 1 mod; 20 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/ffi_cfi.h

66f4cf4b: 8239095: Fixed jcheck
dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
55 lines changed; 55 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/ffi_common.h

66f4cf4b: 8239095: Fixed jcheck
dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
23 lines changed; 21 ins; 0 del; 2 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/ffitarget.h

dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
66 lines changed; 20 ins; 23 del; 23 mod; 81 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/mac/x64/ffi.h

66f4cf4b: 8239095: Fixed jcheck
dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
515 lines changed; 515 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/mac/x64/fficonfig.h

66f4cf4b: 8239095: Fixed jcheck
dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
215 lines changed; 215 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/win/x64/ffi.h

66f4cf4b: 8239095: Fixed jcheck
dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
515 lines changed; 515 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/win/x64/fficonfig.h

dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
215 lines changed; 215 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/win/x86/ffi.h

66f4cf4b: 8239095: Fixed jcheck
dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
515 lines changed; 515 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/win/x86/fficonfig.h

dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
215 lines changed; 215 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/x64/ffi.h

dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
487 lines changed; 0 ins; 487 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/x64/fficonfig.h

dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
215 lines changed; 0 ins; 215 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/x86/ffi.h

dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
487 lines changed; 0 ins; 487 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/x86/fficonfig.h

dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
215 lines changed; 0 ins; 215 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/closures.c

66f4cf4b: 8239095: Fixed jcheck
dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
396 lines changed; 346 ins; 36 del; 14 mod; 606 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/dlmalloc.c

66f4cf4b: 8239095: Fixed jcheck
dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
7 lines changed; 5 ins; 0 del; 2 mod; 5159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/java_raw_api.c

66f4cf4b: 8239095: Fixed jcheck
dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
3 lines changed; 0 ins; 0 del; 3 mod; 371 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/prep_cif.c

66f4cf4b: 8239095: Fixed jcheck
dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
42 lines changed; 21 ins; 11 del; 10 mod; 221 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/raw_api.c

66f4cf4b: 8239095: Fixed jcheck
dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
9 lines changed; 4 ins; 0 del; 5 mod; 262 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/types.c

66f4cf4b: 8239095: Fixed jcheck
dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
3 lines changed; 2 ins; 0 del; 1 mod; 105 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/x86/asmnames.h

66f4cf4b: 8239095: Fixed jcheck
dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
30 lines changed; 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/x86/darwin64.S

dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
416 lines changed; 0 ins; 416 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/x86/ffi.c

66f4cf4b: 8239095: Fixed jcheck
dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
1044 lines changed; 275 ins; 479 del; 290 mod; -283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/x86/ffi64.c

66f4cf4b: 8239095: Fixed jcheck
dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
346 lines changed; 240 ins; 30 del; 76 mod; 540 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/x86/ffiw64.c

66f4cf4b: 8239095: Fixed jcheck
dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
311 lines changed; 311 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/x86/internal.h

66f4cf4b: 8239095: Fixed jcheck
dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
29 lines changed; 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/x86/internal64.h

66f4cf4b: 8239095: Fixed jcheck
dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
22 lines changed; 22 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/x86/sysv_intel.S

dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
995 lines changed; 995 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/x86/unix64.S

66f4cf4b: 8239095: Fixed jcheck
dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
566 lines changed; 566 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/x86/win32.S

dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
1351 lines changed; 0 ins; 1351 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/x86/win64.S

dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
537 lines changed; 19 ins; 310 del; 208 mod; -300 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/x86/win64_intel.S

dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
237 lines changed; 237 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.media/src/main/native/gstreamer/projects/mac/glib-lite/Makefile

dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
1 lines changed; 0 ins; 0 del; 1 mod; 197 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.media/src/main/native/gstreamer/projects/mac/libffi/Makefile

dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
12 lines changed; 3 ins; 0 del; 9 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.media/src/main/native/gstreamer/projects/win/glib-lite/Makefile.ffi

dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
5 lines changed; 0 ins; 0 del; 5 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.media/src/main/native/gstreamer/projects/win/glib-lite/Makefile.gobject

dfe4373e: 8239095: Upgrade libFFI to the latest 3.3 version  
7 lines changed; 0 ins; 0 del; 7 mod; 85 unchg

This code review page was prepared using webrev version f6b8bd88d4f7785cbe6140dc9b14167c9649d18f