| Prepared by: | Abhinay Agarwal on Thu Jun 25 17:46:22 UTC 2020 |
|---|---|
| Compare against: | https://git.openjdk.java.net/jfx |
| Compare against version: | 1cae6a87 |
| Summary of changes: | 95 lines changed; 65 ins; 8 del; 22 mod; 74 unchg |
| Patch of changes: | webrev.patch |
| Pull request: | 219 |
| Legend: | Modified file Deleted file New file |
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
modules/javafx.controls/src/android/java/javafx/scene/control/skin/TextAreaSkinAndroid.java
0aa79029: Show keyboard on mouse event. Focus change listener should be responsible for hiding the keyboard only. 0b22747f: Skin implementation must maintain the contract of dispose 9b7d54f4: Remove listeners in dispose method 6f56d48d: Show keyboard when user taps on TextInput controls49 lines changed; 35 ins; 6 del; 8 mod; 35 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
modules/javafx.controls/src/android/java/javafx/scene/control/skin/TextFieldSkinAndroid.java
0aa79029: Show keyboard on mouse event. Focus change listener should be responsible for hiding the keyboard only. 3024ddcb: Fix typo: dispose should remove event handler 0b22747f: Skin implementation must maintain the contract of dispose 9b7d54f4: Remove listeners in dispose method 6f56d48d: Show keyboard when user taps on TextInput controls46 lines changed; 30 ins; 2 del; 14 mod; 39 unchg
This code review page was prepared using webrev version ca39c57bf150c55fce30c74e2756b7afb0aa0645