Cdiffs Udiffs Sdiffs Frames Old New Patch Raw build.gradle

ca4b818c: Merge remote-tracking branch 'upstream/master' into scriptCompilablePIcompileFallback
119e61b0: Merge master
c4d7cb1b: JDK-8238080 : FXMLLoader: if script engines implement javax.script.Compilable compile scripts
e2519967: test for  JDK-8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV  

4 lines changed; 2 ins; 0 del; 2 mod; 5217 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.fxml/src/main/docs/javafx/fxml/doc-files/introduction_to_fxml.html

f7f9cacb: Incorporating Kevin's review comments.
7ef1bd68: Updates to meet Kevin's comment in PR 192 as of May 27th.
59a16c9f: Reword the compile processing instructions (replace 'Hint' with 'Note:', adjust text to context), remove spurious empty line in script example code.
44b0f9f8: Document the compile processing instruction for scripts.
a0374961: Add missing language processing instruction.
494b8888: Correct typo, replace tabs, remove trailing blanks.  

22 lines changed; 8 ins; 1 del; 13 mod; 1091 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java

f7f9cacb: Incorporating Kevin's review comments.
f2ea3d0e: Incorporating Kevin's review comments (final int, fix for loop test, correct formatting).
7ef1bd68: Updates to meet Kevin's comment in PR 192 as of May 27th.
ca4b818c: Merge remote-tracking branch 'upstream/master' into scriptCompilablePIcompileFallback
a97e758b: Correct ModuleLauncherTest (remove non-existing test), correct formatting.
7c3c2415: Always supply the script's filename in the error message first to further ease spotting the location of script exceptions.
ef93a8f1: Make message more pregnant.
8dd9b001: Compile by default, have fallback if compilation fails, adapt/add test unig
316580b6: add compile process instruction to control compilation of compilable scripts; PI data can be truei (default) or false
119e61b0: Merge master
c4d7cb1b: JDK-8238080 : FXMLLoader: if script engines implement javax.script.Compilable compile scripts
30539592: Removed/replaced white space.
5c33d590: fix for  JDK-8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV  

95 lines changed; 82 ins; 0 del; 13 mod; 3544 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw tests/system/src/test/java/test/launchertest/ModuleLauncherTest.java

c2f5c29c: Revert temporary rename of test method.
a97e758b: Correct ModuleLauncherTest (remove non-existing test), correct formatting.
8dd9b001: Compile by default, have fallback if compilation fails, adapt/add test unig
316580b6: add compile process instruction to control compilation of compilable scripts; PI data can be truei (default) or false
119e61b0: Merge master
c4d7cb1b: JDK-8238080 : FXMLLoader: if script engines implement javax.script.Compilable compile scripts
2db31713: Incorporating Kevin Rushfort's review comments to this WIP.
e2519967: test for  JDK-8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV  

26 lines changed; 26 ins; 0 del; 0 mod; 284 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw tests/system/src/testscriptapp1/resources/mymod/META-INF/services/javax.script.ScriptEngineFactory

0667a8d2: Merge master, correct ovesights.
119e61b0: Merge master
e2519967: test for  JDK-8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV  

1 lines changed; 0 ins; 1 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/java/mymod/module-info.java

c4d7cb1b: JDK-8238080 : FXMLLoader: if script engines implement javax.script.Compilable compile scripts  

34 lines changed; 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/java/mymod/myapp2/Constants.java

c4d7cb1b: JDK-8238080 : FXMLLoader: if script engines implement javax.script.Compilable compile scripts  

37 lines changed; 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/java/mymod/myapp2/FXMLScriptDeployment2Compile_Fail_Compilation.java

f7f9cacb: Incorporating Kevin's review comments.
8dd9b001: Compile by default, have fallback if compilation fails, adapt/add test unig  

286 lines changed; 286 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/java/mymod/myapp2/FXMLScriptDeployment2Compile_Off.java

316580b6: add compile process instruction to control compilation of compilable scripts; PI data can be truei (default) or false  

286 lines changed; 286 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/java/mymod/myapp2/FXMLScriptDeployment2Compile_Off_On.java

316580b6: add compile process instruction to control compilation of compilable scripts; PI data can be truei (default) or false  

286 lines changed; 286 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/java/mymod/myapp2/FXMLScriptDeployment2Compile_On.java

316580b6: add compile process instruction to control compilation of compilable scripts; PI data can be truei (default) or false  

286 lines changed; 286 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/java/mymod/myapp2/FXMLScriptDeployment2Compile_On_Off.java

316580b6: add compile process instruction to control compilation of compilable scripts; PI data can be truei (default) or false  

286 lines changed; 286 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/java/mymod/myapp2/Util.java

c4d7cb1b: JDK-8238080 : FXMLLoader: if script engines implement javax.script.Compilable compile scripts  

114 lines changed; 114 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/java/mymod/pseudoScriptEngineCompilable/InvocationInfos.java

f7f9cacb: Incorporating Kevin's review comments.
ea0a8f2e: appease the jcheck script, such that that important trailing Whitespace error can be resolved (why would jcheck not do it automagically as well as expanding tabs?)
119e61b0: Merge master
c4d7cb1b: JDK-8238080 : FXMLLoader: if script engines implement javax.script.Compilable compile scripts  

77 lines changed; 77 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/java/mymod/pseudoScriptEngineCompilable/RgfPseudoCompiledScript.java

f7f9cacb: Incorporating Kevin's review comments.
c4d7cb1b: JDK-8238080 : FXMLLoader: if script engines implement javax.script.Compilable compile scripts  

58 lines changed; 58 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/java/mymod/pseudoScriptEngineCompilable/RgfPseudoScriptEngineCompilable.java

f7f9cacb: Incorporating Kevin's review comments.
8dd9b001: Compile by default, have fallback if compilation fails, adapt/add test unig
ea0a8f2e: appease the jcheck script, such that that important trailing Whitespace error can be resolved (why would jcheck not do it automagically as well as expanding tabs?)
119e61b0: Merge master
c4d7cb1b: JDK-8238080 : FXMLLoader: if script engines implement javax.script.Compilable compile scripts  

141 lines changed; 141 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/java/mymod/pseudoScriptEngineCompilable/RgfPseudoScriptEngineCompilableFactory.java

c4d7cb1b: JDK-8238080 : FXMLLoader: if script engines implement javax.script.Compilable compile scripts  

140 lines changed; 140 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/resources/mymod/META-INF/services/javax.script.ScriptEngineFactory

119e61b0: Merge master
c4d7cb1b: JDK-8238080 : FXMLLoader: if script engines implement javax.script.Compilable compile scripts  

1 lines changed; 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/resources/mymod/myapp2/demo_02_bottomscript.sqtmc

119e61b0: Merge master
c4d7cb1b: JDK-8238080 : FXMLLoader: if script engines implement javax.script.Compilable compile scripts  

1 lines changed; 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/resources/mymod/myapp2/demo_02_middlescript.sqtmc

119e61b0: Merge master
c4d7cb1b: JDK-8238080 : FXMLLoader: if script engines implement javax.script.Compilable compile scripts  

1 lines changed; 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/resources/mymod/myapp2/demo_02_off.fxml

8dd9b001: Compile by default, have fallback if compilation fails, adapt/add test unig
316580b6: add compile process instruction to control compilation of compilable scripts; PI data can be truei (default) or false  

70 lines changed; 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/resources/mymod/myapp2/demo_02_off_on.fxml

316580b6: add compile process instruction to control compilation of compilable scripts; PI data can be truei (default) or false  

69 lines changed; 69 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/resources/mymod/myapp2/demo_02_on.fxml

59b66d33: Make sure we test the default behaviour to compile script by leaving out the compile PI.
316580b6: add compile process instruction to control compilation of compilable scripts; PI data can be truei (default) or false  

69 lines changed; 69 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/resources/mymod/myapp2/demo_02_on_off.fxml

316580b6: add compile process instruction to control compilation of compilable scripts; PI data can be truei (default) or false  

69 lines changed; 69 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/resources/mymod/myapp2/demo_02_topscript.sqtmc

119e61b0: Merge master
c4d7cb1b: JDK-8238080 : FXMLLoader: if script engines implement javax.script.Compilable compile scripts  

1 lines changed; 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/resources/mymod/myapp2/demo_03_bottomscript.sqtmc

8dd9b001: Compile by default, have fallback if compilation fails, adapt/add test unig  

2 lines changed; 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/resources/mymod/myapp2/demo_03_fail_compile.fxml

8dd9b001: Compile by default, have fallback if compilation fails, adapt/add test unig  

69 lines changed; 69 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/resources/mymod/myapp2/demo_03_middlescript.sqtmc

8dd9b001: Compile by default, have fallback if compilation fails, adapt/add test unig  

2 lines changed; 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw tests/system/src/testscriptapp2/resources/mymod/myapp2/demo_03_topscript.sqtmc

8dd9b001: Compile by default, have fallback if compilation fails, adapt/add test unig  

2 lines changed; 2 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using webrev version ca39c57bf150c55fce30c74e2756b7afb0aa0645